search

spitschan / SilentSubstitutionToolbox

Toolbox to simulate colorimetric observers for evaluation of photoreceptor isolation
Other
7 stars 5 forks source link

ComputeAndReportContrastsFromSpds needs input and output arguments clarified #10

Closed spitschan closed 7 years ago

spitschan commented 7 years ago

Fixed in https://github.com/spitschan/SilentSubstitutionToolbox/commit/b79ee722bc1fbe2c2020a58c2546a8334ade3837.

@DavidBrainard: Could you verify that the logic that calculates the the postreceptoral contrasts in line 78 of ComputeAndReportContrastsFromSpds. Thanks.

DavidBrainard commented 7 years ago

To save me a little hunting, what is a program that calls this routine and illustrates it in action?

spitschan commented 7 years ago

E.g. the output of the countrast during spectrum seeking: https://github.com/DavidBrainard/OneLightToolbox/blob/adcd203d81c8e33dfdec81e3aacb04a57b9528b9/OLLibrary/OLCorrectCacheFileOOC.m

DavidBrainard commented 7 years ago

DB to check post-receptoral contrast logic.

spitschan commented 7 years ago

Flagging this again for @DavidBrainard.

DavidBrainard commented 7 years ago

I haven't forgotten. Will pass through this when I update the validation analysis code for the OneLight project.

spitschan commented 7 years ago

Closing this, as superseded by https://github.com/spitschan/SilentSubstitutionToolbox/issues/19