Add a warning log if evaluating with flag sets that don't contain feature flags.
Updated storage method signature as in the spec: getNamesByFlagSets(flagSets: string[]): MaybeThenable<ISet<string>> -> getNamesByFlagSets(flagSets: string[]): MaybeThenable<ISet<string>[]>, to properly log which flag sets don't contain cached feature flags.
Update evaluateFeaturesByFlagSets to avoid calling storage::getSplits method with an empty array if there are no feature flags to evaluate, in order to avoid an error with Redis storage.
Javascript commons library
What did you accomplish?
getNamesByFlagSets(flagSets: string[]): MaybeThenable<ISet<string>>
->getNamesByFlagSets(flagSets: string[]): MaybeThenable<ISet<string>[]>
, to properly log which flag sets don't contain cached feature flags.evaluateFeaturesByFlagSets
to avoid callingstorage::getSplits
method with an empty array if there are no feature flags to evaluate, in order to avoid an error with Redis storage.How do we test the changes introduced in this PR?
Unit tests
Extra Notes