search

splunk / ansible-role-for-splunk

Splunk@Splunk's Ansible role for installing Splunk, upgrading Splunk, and installing apps/addons on Splunk deployments (VM/bare metal)
Apache License 2.0
146 stars 102 forks source link

Changes needed to support both old and new cluster configuration #217

Open BSonPosh opened 9 months ago

BSonPosh commented 9 months ago

8.1< slave/master 8.1 >= peer/manager

BSonPosh commented 2 weeks ago

I don’t think I did that. Good catch

On Fri, Aug 30, 2024 at 8:55 AM dtwersky @.***> wrote:

@.**** commented on this pull request.

In roles/splunk/tasks/configure_idxc_manager.yml https://github.com/splunk/ansible-role-for-splunk/pull/217#discussion_r1736918568 :

set_fact:

  • mode_value: "{% if splunk_version_release | float < 8.1 %}master{% else %}manager{% endif %}"
  • mode_value: "manager"

Have you tried using the old method but changing it from float to version? Using float was wrong because it will fail in some cases when there are micro releases.

— Reply to this email directly, view it on GitHub https://github.com/splunk/ansible-role-for-splunk/pull/217#pullrequestreview-2269819552, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE6UWZXMZLOJJVS5MXIP33ZUBTV3AVCNFSM6AAAAABNLAEHWGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENRZHAYTSNJVGI . You are receiving this because you authored the thread.Message ID: @.***>