configure_dmc.yml breaks Cluster Manager config if DMC runs on CM

splunk / ansible-role-for-splunk

Splunk@Splunk's Ansible role for installing Splunk, upgrading Splunk, and installing apps/addons on Splunk deployments (VM/bare metal)

Apache License 2.0

147 stars 103 forks source link

configure_dmc.yml breaks Cluster Manager config if DMC runs on CM #224

Open igsher opened 6 months ago

igsher commented 6 months ago

Task "Configure DMC as a IDXC member" in configure_dmc.yml attempts to configure the node as IDXC SH even if the node is already configured as IDXC Manager

Proposed fix:

- name: Configure DMC as a IDXC member
  include_tasks: configure_idxc_sh.yml
  when:
    - "'clustermanager' not in group_names"

arcsector commented 3 months ago

DMC shouldn't run on the CM as per Splunk's docs, but this is an easy PR to make, feel free to submit it.

igsher commented 2 months ago

DMC shouldn't run on the CM as per Splunk's docs ...

That's incorrect. The docs actually say here and here that under specific circumstances DMC can be colocated on the manager node.