search

splunk / utbox

URL Toolbox (UTBox) is a set of building blocks for Splunk specially created for URL manipulation. UTBox has been created to be modular, easy to use and easy to deploy in any Splunk environments.
https://preview.splunkbase.splunk.com/app/2734/
Apache License 2.0
8 stars 6 forks source link

added log max size & backup count #9

Closed satellite-no closed 1 year ago

satellite-no commented 1 year ago

Added maxBytes & backupCount to stop the log from from growing out of control and consuming all of the disk space. Note this is best practice to include per https://docs.python.org/3/library/logging.handlers.html#logging.handlers.RotatingFileHandler.

Closes #8

satellite-no commented 1 year ago

@dfederschmidt could you take a look at this PR.

dfederschmidt commented 1 year ago

@satellite-no Thanks for opening the PR and reporting this issue. I moved teams internally and am not able to release this app on my own anymore. I forwarded this to the appropriate person to take a look. Thanks again!

mayurah commented 1 year ago

@dfederschmidt @ggokdemir can test this change, and we can get this merged soon.

ggokdemir commented 1 year ago

@satellite-no I'll have a look. Thanks for your help!