Schema registry SSL config propagation to producer and consumer confgurations

spring-cloud / spring-cloud-stream

Framework for building Event-Driven Microservices

http://cloud.spring.io/spring-cloud-stream

Apache License 2.0

1.01k stars 614 forks source link

Schema registry SSL config propagation to producer and consumer confgurations #2897

Closed srinivasboini closed 9 months ago

srinivasboini commented 9 months ago

When providing schema registry SSL properties under Kafka binder configuration, those properties are not being propagated to producer configurations and consumer configurations This is necessary for certain serializer/deserializer to work.

This change will fix https://github.com/spring-cloud/spring-cloud-stream/issues/2882 .

sobychacko commented 9 months ago

@srinivasboini There are checkstyle errors in the build. See here for more details: https://github.com/spring-cloud/spring-cloud-stream/actions/runs/7809133976/job/21321940736?pr=2897 Could you address them?

srinivasboini commented 9 months ago

@sobychacko My bad. It was using default configs for chekcstyles. I fixed them. please have a look.

sobychacko commented 9 months ago

Thanks, @srinivasboini for the PR. It is now squashed and merged upstream. I also back-ported the changes to 4.0.x.

srinivasboini commented 9 months ago

@sobychacko Many thanks for merging the changes.