spring-projects / spring-data-neo4j

Provide support to increase developer productivity in Java when using Neo4j. Uses familiar Spring concepts such as a template classes for core API usage and lightweight repository style data access.
http://spring.io/projects/spring-data-neo4j
Apache License 2.0
838 stars 618 forks source link

Remove logback.xml embedded inside spring-data-neo4j-4.0.0.RELEASE*-tests*.jar [DATAGRAPH-821] #1383

Closed spring-projects-issues closed 6 years ago

spring-projects-issues commented 8 years ago

Selwyn Jacobs opened DATAGRAPH-821 and commented

spring-data-neo4j-4.0.0.RELEASE-tests.jar has an embedded logback.xml that is being picked up in my spring-boot application and overriding default logback impl. I had a discussion with Andy Wilkerson (pivotal team member) and he recommend to file a bug. Please see stackoverflow link for further details.


Affects: 4.0 GA

Reference URL: http://stackoverflow.com/questions/35148254/override-pattern-ignored-when-setting-properties-logging-pattern-console-or-logg/35153859?noredirect=1#comment58039814_35153859

spring-projects-issues commented 8 years ago

Selwyn Jacobs commented

This is an mistake on my part. I was importing test-jars but I did not explicitly set the scope to test so it was being resovled as a compile time scope by maven.

    <dependency>
        <groupId>org.neo4j.app</groupId>
        <artifactId>neo4j-server</artifactId>
        <version>${neo4j.version}</version>
        <type>test-jar</type>
        <scope>test</scope>
    </dependency>

    <dependency>
        <groupId>org.neo4j</groupId>
        <artifactId>neo4j-ogm</artifactId>
        <version>${neo4j.ogm.version}</version>
        <type>test-jar</type>
        *<scope>test</scope>*
    </dependency>

    <dependency>
        <groupId>org.neo4j.test</groupId>
        <artifactId>neo4j-harness</artifactId>
        <version>${neo4j.version}</version>
        *<scope>test</scope>*
    </dependency>

NoneTheLess, maybe still remove the logback.xml embedded in jars?

There is also one inside neo4jServer jar

Downgrading to trivial.

spring-projects-issues commented 6 years ago

Gerrit Meier commented

We went through the old issues and tried to judge wether they are still applicable or not. If you feel this is important, please file a new issues and refer to the old one. Thanks a lot