search

spring-projects / spring-data-neo4j

Provide support to increase developer productivity in Java when using Neo4j. Uses familiar Spring concepts such as a template classes for core API usage and lightweight repository style data access.
http://spring.io/projects/spring-data-neo4j
Apache License 2.0
835 stars 618 forks source link

issue/2953 #2962

Open mkoertgen opened 1 month ago

mkoertgen commented 1 month ago

fixes #2953

meistermeier commented 1 month ago

Thanks a lot. I hope to have a look later this week (🤞 )

meistermeier commented 3 weeks ago

Thanks again for this PR. I think it makes sense in this way, even though I am not completely happy with the syntax of readOnlyTxManager....(...., readOnly=true). It feels somehow like a duplication. On the other hand I see no way how the write-mode transaction manager in the executable query should know that it is about to join an ongoing transaction.

Something that is missing in the PR is the support for the reactive template manager (you're missing all the fun ;) ) Unfortunately there is no validate method on the reactive transaction manager that will help us (you) to verify that this is working, or I cannot find it right now.

mkoertgen commented 2 weeks ago

Hi @meistermeier ,

Will add the reactive part. Thanks for reviewing 👍

mkoertgen commented 1 week ago

Hi @meistermeier ,

As of now, AbstractReactiveTransactionManager does not support transactional validation as does AbstractPlatformTransactionManager.setValidateExistingTransaction.

So it does not make sense to add it now.