search

spring-projects / spring-net

Spring Framework for .NET
http://www.springframework.net
Apache License 2.0
850 stars 377 forks source link

Spring.Web.AspNetCore Support? #210

Closed superboy1984 closed 2 years ago

superboy1984 commented 3 years ago

any plan for supprort AspNetCore?

lahma commented 3 years ago

No such plans, but if you would like to champion the feature and build it I think it would be very welcome. Biggest obstacle probably is that Spring.NET doesn't have scoped objects concept.

maulik-modi commented 3 years ago

@lahma, release note reads: .NET Core / >= NET5 support via .NET Standard 2.0 library targets for all core projects and integration projects which offer .NET standard compatible libraries

Does this mean, it can run on Linux/Cross platform technologies?

lahma commented 3 years ago

@maulik-modi tests are run on both Windows and Linux. So the library should work on both platforms, but there might be some differences not spotted yet as 3.0 brought the cross-platform support.

maulik-modi commented 3 years ago

@lahma , I am thinking to contribute - Spring.Microsoft.DependencyInjection bridge if 3.0 is stable and test cases are passing against .net 5. Do you see any road block?

Inspiration: https://github.com/JasperFx/lamar/tree/master/src/Lamar.Microsoft.DependencyInjection

lahma commented 3 years ago

Sounds good!

maulik-modi commented 3 years ago

@lahma , I see that https://github.com/spring-projects/spring-net/actions/runs/1105761071 runs windows builds using .net 4.6.X and runs Linux builds using .net 5.0

Linux build is passing these projects, it does not include Spring.Web.Tests because System.web.mvc is not cross platform, Is there any way Build/Test project status can be published on https://github.com/spring-projects/spring-net e.g. Quartz project shows build status image

lahma commented 3 years ago

I've added some badges to main readme, there's no sub-project level info for builds as everything is built and tested together.

maulik-modi commented 3 years ago

@lahma thats superb; In the past I had used Coverlet to generate code coverage reports with Jenkins, https://samlearnsazure.blog/2021/01/05/code-coverage-in-github-with-net-core/ help getting started This will bring more transparency and confidence

lahma commented 3 years ago

A PR would be nice 😉

lahma commented 2 years ago

I'm doing a rude experiment with closing this, like what stale bot does, but maybe more human as I will probably actually react to feedback. As this issue has been stale for so long, I'll close it. If it's still an issue you would like to pursue, we can definitely reopen.

With limited resources this is just something that we need to do. Thank you for your understanding.