Implement Wagtail 1.12 'features' lists

springload / wagtaildraftail

🐦📝🍸 Draft.js editor for Wagtail, built upon Draftail and draftjs_exporter

https://pypi.python.org/pypi/wagtaildraftail

MIT License

24 stars 3 forks source link

Implement Wagtail 1.12 'features' lists #63

Closed gasman closed 6 years ago

gasman commented 6 years ago

Add support for the features kwarg on DraftailTextField and DraftailTextBlock (and within WAGTAILADMIN_RICH_TEXT_EDITORS). This was introduced on RichTextField and RichTextBlock in Wagtail 1.12 to allow configuring the feature set of rich text fields in an editor-agnostic way, with the intention that it would allow a clean transition from Hallo.js to something better (such as Draftail :-) )

loicteixeira commented 6 years ago

@thibaudcolas The front-end tests are failing. The PR doesn't change any front-end file but does change the default set of features I guess, so does that mean the snapshots need to be updated?

loicteixeira commented 6 years ago

Coverage is down mostly because tests are run with the py36-dj111-wt110 environment so all the Wagtail >= 1.12 branches aren't run. Overall coverage will need some work anyway so I'll merge this regardless.

Thanks again @gasman!