search

sproutcore / rich-text-editor

A rich text editor for SproutCore.
Other
6 stars 6 forks source link

Selecting a tool in toolbar doesn't give it the isSelected state until typing #20

Closed tobias-g closed 10 years ago

tobias-g commented 10 years ago

When you select a tool (i.e. bold, italic etc.) via clicking it in the toolbar its element doesn't gain the "sel" classname until the user begins typing in the editor.

This is because "editorStateDidChange" functions don't get called unless the editors value changes when they should be called when the editors state changes regardless of value change.

My proposed fix is https://github.com/tobias-g/rich-text-editor/compare/toolbar_selection_fix

dcporter commented 10 years ago

Fix looks good. Please pull req!