squeek502 / VeganOption

A Minecraft mod that seeks to add vegan alternatives to all Minecraft mob/animal products
The Unlicense
46 stars 10 forks source link

Basin does not catch Raw Ender from > 1 block above #106

Closed elifoster closed 8 months ago

elifoster commented 9 months ago

For example (note: the basin is open by redstone underneath): 2024-01-08_21 08 36

Notably, it works for regular source-flowing fluid blocks (water, lava)

elifoster commented 8 months ago

This is caused by the raw ender constantly updating neighbors inside FlowingFluid#tick. When the basin is updated it resets the consume timer, so it never is able to consume. The issue seems to be that when the FlowingFluid is handling flow/spread, the FluidState it creates is different from the one which already exists, ie there is a discrepancy between what FlowingFluid expects and what RawEnderFluid creates.