squeek502 / VeganOption

A Minecraft mod that seeks to add vegan alternatives to all Minecraft mob/animal products
The Unlicense
45 stars 10 forks source link

Sometime, resin is quite infrequent. #30

Closed kane-thornwyrd closed 9 years ago

kane-thornwyrd commented 9 years ago

Hello Squeek,

I made some tests, and in the case people use TConstruct the resin drops are really rare, like once in 10 trees, if Treecapitator is also in use, resin become rarer than diamond, literally.

I don't know which stand you will take about this, but my advice would be to totally avoid the issue by adding a resin collector like what Electrical Age guys do:

Electrical Age Repo Resin Collector

Or even IC² with their resin tap.

Thank you for your attention :)

squeek502 commented 9 years ago

Interesting. I would have thought that the drops would be compatible with things like lumber axes/treecapitator. I'll make sure to test that and see if anything's going wrong.

I like that resin collector solution, though.

kane-thornwyrd commented 9 years ago

I honestly think that the bug is on their side, because at the end of the day they are those whom implemented their own "felling algorithm" that doesn't seems to fire HarvestDropsEvent for each blocks chopped.

squeek502 commented 9 years ago

Right, that's what I thought as well, but it looks like the TCon code should work. From here it calls the vanilla method block.harvestBlock(world, player, x,y,z, meta);, which does fire the HarvestDropsEvent.

Once I am able to test it, I'll set the drop chance of resin to 100% and see if it drops the correct amount.

squeek502 commented 9 years ago

TCon Lumber Axes seems to work as expected for me. When I set the drop chance to 100%, I got 6 resin and 6 spruce wood when I chopped down a tree.

Perhaps you just got unlucky? How did you test it?

kane-thornwyrd commented 9 years ago

True, it's strange it's so rare with only TC though. :confused: And Treecapitator, just not.... Anyway, imho this part of the problem is still not your concern, I'll ask Bspkrs if he use a trick to anyway fire this event.

squeek502 commented 9 years ago

Do you have stackDrops set to true in your Treecapitator config? Looks like that's the only setting that'd bypass the HarvestDropsEvent being fired.

EDIT: Relevant code for Treecapitator for reference: https://github.com/bspkrs/Treecapitator/blob/1.7.10/src/main/java/bspkrs/treecapitator/Treecapitator.java#L605-L610

kane-thornwyrd commented 9 years ago

Answer to your question I have been unlucky then, protocol:

I'll write down the test of a batch of 50 trees here, plus you gave me the idea to submit my "testbed modpack" as reference.

kane-thornwyrd commented 9 years ago

Ooooh, okay :sweat:

squeek502 commented 9 years ago

I'll submit a bug report on the Treecapitator issue tracker. It's something that would be good to get fixed.

kane-thornwyrd commented 9 years ago

Thank you A LOT !

kane-thornwyrd commented 9 years ago

For now on, I'll use this modpack to test, as a "stable base". BTW, You're credited :wink:

kane-thornwyrd commented 9 years ago

Results time: for 64 trees, I got 36 resin using the TConstruct lumber axe.

I may have found an exploit too.

squeek502 commented 9 years ago

Is the exploit that you can break a spruce block, place it back down, break it again, get resin again, and repeat? If so, I am aware but am not quite sure how to fix it yet.

kane-thornwyrd commented 9 years ago

yes, but don't worry too much, to become really "fun" those who want to use it should make some serious redstone first ^^

ghost commented 8 years ago

I've noticed the same with Rotarycraft woodcutter and bedrock axe.

squeek502 commented 8 years ago

@reteo same problem as Treecapitator. Adding a resin collector is looking better and better.

ReikaKalseki commented 8 years ago

The bedrock axe is not. It does not use BlockArray (though it used to). Instead it uses a TickHandler, ProgressiveRecursiveBreaker.

squeek502 commented 8 years ago

I guess that means that ProgressiveRecursiveBreaker needs HarvestDropsEvent support as well.