search

squeek502 / VeganOption

A Minecraft mod that seeks to add vegan alternatives to all Minecraft mob/animal products
The Unlicense
45 stars 10 forks source link

Fix soap clearing potion effects that it shouldn't #50

Closed squeek502 closed 8 years ago

squeek502 commented 8 years ago

As suggested by /u/BluSunrize on Reddit. Would also fix the "soap can clear warp-related effects from Thaumcraft" part of #18

In other words, how could Thaumic Tinkerer fix this problem?

By checking if the list for healing items is empty or even just isn't milk. If it is, the effect is probably not meant to be healed.

Ah, alright, so loop through the active potion effects and only remove those that satisfy effect.getCurativeItems().length > 0? Doesn't sound like a bad way of doing it.