Closed elifoster closed 7 years ago
I generally try to avoid adding full mods to the dev environment whenever possible (to better test that they are optional and to keep the default environment lean), but it looks like that's not really possible with TOP, unfortunately. Perhaps we could request API-only packages be added to the TOP maven.
I've moved DEGREE_SYMBOL
so that the TOP integration is not dependent on the WAILA integration classes.
I agree with the API package stuff. Are we going to wait until McJty/TheOneProbe#66 is resolved to merge this, or simply update the buildscript once that issue gets resolved?
Looks good, we can merge it now.
What do you think of the two potential improvements I listed above?
getContextStrings
that would return a List<String>
and then the TOP methods could just loop through that and chain text
calls, but Waila depends on NBT syncing that might make that method not quite work without special handling (for example).
WAILA integration and The One Probe integration are 1:1; what was already shown in the WAILA tooltip is shown in The One Probe tooltip. Remove Bed WAILA integration and replace it with properly overriding getPickBlock in BlockBedGeneric.
Here is an example of what it looks like:
Open and empty basin:![Open and empty basin](https://puu.sh/rFE48/8ff5a22663.png)
Closed and full basin:![Closed and full basin](https://puu.sh/rFE9H/ef1cb27539.png)
Potential improvements I can think of:
toolTip.add(String.format("%s : %d%%", LangHelper.translate("waila.composter.composting"), (int) (tag.getFloat("Compost") * 100f)));
would becometoolTip.add(LangHelper.translate("waila.composter.composting", (int) (tag.getFloat("Compost") * 100f));
and likewise for the The One Probe equivalent code.