search

squeek502 / VeganOption

A Minecraft mod that seeks to add vegan alternatives to all Minecraft mob/animal products
The Unlicense
45 stars 10 forks source link

[1.10.2] UniversalBucket behaving strangely with OreDict / JEI #87

Closed squeek502 closed 7 months ago

squeek502 commented 7 years ago

Because the universal bucket uses NBT to differentiate types, adding one of our buckets to an ore dictionary entry means that it seems to have some weirdness when added to oredict (in this case, listAllmilk for plant milk). The strange thing is, this doesn't actually seem to affect recipe usage, but the oredict shows up in OreDictTips for all universal buckets.

Also, weird things are happening with regards to the JEI usage/crafting stuff in VO, where the entries of buckets are combined in weird ways.

elifoster commented 7 years ago

This sounds like it might be an issue within Forge's OreDictionary implementation rather than on our end but I'd have to look into it a bit more. Could also just be an issue with OreDictTips although that mod is extremely simple so it's doubtful.

squeek502 commented 7 years ago

I was wrong about the effects--it actually does affect recipes (Raw Ender Bucket works in recipes that take a Plant Milk Bucket [as well as any other Universal Bucket instance, including from other mods]) but it doesn't show up in JEI, so OreDictTips is right and JEI just obscures the effects.

OreDictionary has no concept of NBT in any of its checks/hashes/etc, so we might need to drop the Universal Bucket for things we want to add to the Ore Dictionary.

elifoster commented 7 years ago

See also MinecraftForge/MinecraftForge#4165