search

srexi / purecounterjs

A simple yet configurable native javascript counter which you can count on.
MIT License
125 stars 47 forks source link

Version does not match current tag #19

Closed williamdes closed 3 years ago

williamdes commented 3 years ago

https://github.com/srexi/purecounterjs/blob/b0668b1f15310189577b0ccee5285c44790a99ab/dist/purecounter.js#L4

Seems like it would need a bump before making a tag :)

srexi commented 3 years ago

fixed thanks: https://github.com/srexi/purecounterjs/commit/cbf4b034cba3391cd3d40855fd1433f7703baa74

williamdes commented 3 years ago

Could you re-build bundle files and publish a tag please ?

williamdes commented 3 years ago

My point is that the version people will download using tag 1.2.0 will say version 1.1.4 and it will confuse people ;) (on bundle files)

williamdes commented 3 years ago

Maybe just delete tag 1.2.1 and publish it back after bundle update :)

I can make a PR if you do not have the repo locally ready

srexi commented 3 years ago

Yeah I think this will do for now