search

srg-kostyrko / obsidian-journal

MIT License
96 stars 7 forks source link

Inconsistent "Folder" setting #4

Closed Cito closed 6 months ago

Cito commented 6 months ago

I noticed that the "Folder" setting works differently for calendar and interval based journals. For calendar based journals, this folder is interpreted as relative to the folder configured in the core daily notes plugin, whereas for interval based journals, it is relative to the root path. Is this difference intended? If yes, it would be helpful to mention it on the settings page.

srg-kostyrko commented 6 months ago

Calendar based journals have additional setting Root folder and section(daily, weekly etc.) folders are relative to it. Maybe in your case that root folder is the same as folder configured in the core daily notes plugin and that is why it looks like it took settings from core plugin.

I'll add more details to folder setting description for clarity.

Cito commented 6 months ago

Thanks - you're right, that was in fact the case. I overlooked it because the Root folder setting is not part of the same dialog, but in the parent dialog. If you just add some words about this where the Folder setting is shown, this would be sufficient.

srg-kostyrko commented 6 months ago

Yeh that will be done in https://github.com/srg-kostyrko/obsidian-journal/issues/8