sryza / spark-timeseries

A library for time series analysis on Apache Spark
Apache License 2.0
1.19k stars 424 forks source link

correct #143 ARIMA forecast errors if p and q are both zero #171

Closed TiagoDinisFonseca closed 7 years ago

TiagoDinisFonseca commented 7 years ago

when p and q are both zero it ignores a step

jgustave commented 7 years ago

Thanks for the patch, and the great software. I ran in to the same issue. Look forward to the merge.

TiagoDinisFonseca commented 7 years ago

My fault... I gave up of the project where I was trying to use spark-ts. But come on, I can add the space. Sorry about the delay.

jgustave commented 7 years ago

You are the best, thanks! -JD

On Nov 23, 2016, at 4:50 PM, Tiago Dinis da Fonseca notifications@github.com wrote:

My fault... I gave up of the project where I was trying to use spark-ts. But come on, I can add the space. Sorry about the delay.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sryza/spark-timeseries/pull/171#issuecomment-262664887, or mute the thread https://github.com/notifications/unsubscribe-auth/AA6dsJa5rzCUfF_lgTFnPgc-pFJSKWfkks5rBN9kgaJpZM4KWBYo.

sryza commented 7 years ago

LGTM! Merging this.