search

ssbc / ssb-conn

SSB plugin for establishing and managing peer connections
MIT License
16 stars 5 forks source link

Defunctness causes no pubs to be attempted #15

Closed staltz closed 4 years ago

staltz commented 4 years ago

See discussion at https://github.com/ssbc/patchwork/pull/1242

Apparently I did a big mistake with booleans:

https://github.com/staltz/ssb-conn/blob/5758e5b5fa143273d2ed2fcb7ae87de27fe43314/src/conn-scheduler.ts#L50-L56

:scream: :scream: :scream:

staltz commented 4 years ago

cc @christianbundy @cinnamon-bun

christianbundy commented 4 years ago

Thanks for finding and fixing this so quickly! :heart:

staltz commented 4 years ago

Hot fixed in 0.16.2.

Should probably bring back defunctness in the future, but very carefully. With code reviews, tests, and recovery from defunctness (see #14).