search

ssbc / ssb-conn

SSB plugin for establishing and managing peer connections
MIT License
16 stars 5 forks source link

Eliminate "zii" dependency #26

Closed KyleMaas closed 3 years ago

KyleMaas commented 3 years ago

Having zii pulled in makes it so that IPFS can't be combined into the same project as ssb-conn. Reported upstream here:

https://github.com/multiformats/js-multibase/issues/80

...but I'm not sure they can fix this well without breaking their API, so it would be better if zii could be eliminated from this project. It's too wide-reaching, and I could see it causing other odd corner cases in other places in the future.

KyleMaas commented 3 years ago

By the way, the reason for trying to use IPFS is so that I can do this:

https://github.com/arj03/ssb-browser-demo/issues/198

staltz commented 3 years ago

Yeah I'm inclined to replace zii with something else

KyleMaas commented 3 years ago

Cool. It does look like it simplifies things and keeps code short. It's just that, unfortunately, it has side effects.

KyleMaas commented 3 years ago

Solved with https://github.com/staltz/ssb-conn/commit/ec2a2661f534fb6b87628d0ccd6204270a611af3

staltz commented 3 years ago

Version 2.0.2 should solve this