ssvlabs / ssv-dkg

GNU General Public License v3.0
11 stars 9 forks source link

More helpful log(s) #106

Open RaekwonIII opened 3 weeks ago

RaekwonIII commented 3 weeks ago

Candidates applying for the position of Operator Technical Support have been asked to setup a DKG node and complete a DKG ceremony with their own node and 3 others. Needless to say, this was a much more difficult task than I had anticipated 😅

In great part, this is because the assignment did not specify which other 3 operators to choose, so the candidates came across a variety of issues. Reporting here a couple of them, for which I actually don't have an answer to, or don't know the cause:

2024-08-01T17:17:54.193028Z FATAL dkg-initiator 😥 Failed to load operators: {"error": "😥 Failed to load operators: invalid operator public key decode PEM block"}

I think I saw this in the past, but forgot what it was due to. I suspect it was users not actually using https, but I cannot be sure.

2024-08-02T17:50:51.817220Z FATAL dkg-initiator 😥 Failed to initiate DKG ceremony: {"error": "invalid ssz encoding. first variable element offset indexes into fixed value data"}

This one, we know of:

2024-08-01T17:34:28.306252Z FATAL dkg-initiator 😥 Failed to initiate DKG ceremony: {"error": "incorrect offset"}

But "incorrect offset" is not a very helpful log error. Saying "operator XYX probably is using an outdated version" is much more helpful...

pavelkrolevets commented 17 hours ago

These vague errors incorrect offset, invalid ssz encoding is related to fastssz library when we try to decode []bytes to a different struct which was changed after updates. Not much we can do here, but Ill add more info to error logs related to ssz encoding/decoding to check the version. Hope this can help users.

pavelkrolevets commented 13 hours ago

wrapped errors and added messages to ssz errors PR https://github.com/ssvlabs/ssv-dkg/pull/124