search

stack-of-tasks / install-sot

Bash script to install the repositories of Stack Of Tasks
0 stars 7 forks source link

Modify the packages branch in order to install the stack-of-tasks with e... #13

Closed elie-moussy closed 5 years ago

elie-moussy commented 11 years ago

Please accept my PR in order to use a stack of tasks working with eigen.

francois-keith commented 11 years ago

Hello,

I think there is a problem with this pull request. As I understand it, the purpose of this new script is to pull all the eigen versions of the packages for test purpose. Once the tests finished, all of those branches will be rebased with the master of each packages and the fork will be destroyed.

The problem is that, for now, you do not point any of your repositories, but only the ones in the original repositories (in https://github.com/stack-of-tasks, https://github.com/laas, https://github.com/jrl). As a result, the branches pulled are not the right ones (or worst, deprecated ones). I've corrected those paths according to this hypothesis there: https://github.com/francois-keith/install-sot/blob/topic/eigen/scripts/install_sot.sh

Also, please note that with the branch topic/eigen of abstract-robot-dynamic, jrl-dynamics does not compile anymore. So either the script is wrong and the master branch should be used rather than the topic/eigen, or some modifications should be applied on jrl-dynamics.

Regards

François

elie-moussy commented 11 years ago

Thank you for changing the paths. I have updated this modification in my repository. As for abstract-robot-dynamic, I have rebased my work on the master and I have pushed the new topic/eigen. I will now try to see if everthing can be installed in the stack of task. I will keep you informed ;).

Regards.

Elie

elie-moussy commented 11 years ago

It's working for me now. Can you retest it and confirm please?

francois-keith commented 11 years ago

Hello

It's working, but some small modifications are still required:

The package hrp2-10-optimized didn't have a topic/eigen branch, preventing its computation (this is why I commented it). As a result, the package sot-hrp2 couldn't be compiled (since both are needed). I made a pull request on your branch to this purpose. One accepted, please re-allow the computation of hrp2-10-optimized to enable the computation of sot-hrp2.

The branch topic/eigen from dynamic_graph_bridge is not pulled automatically. To do so, it would require changing the laas.rosinstall file, in order to get the good version of redundant_manipulator_control. (https://github.com/laas/ros/blob/master/laas.rosinstall), ie the one you will fork, and in which you will replace the current version of dg_bridge with yours.

Also, there is an issue on robot_model_py for fuerte, but it is mentioned elsewhere.

Regards

On Tue, Sep 17, 2013 at 11:19 AM, Elie Moussy notifications@github.comwrote:

It's working for me now. Can you retest it and confirm please?

— Reply to this email directly or view it on GitHubhttps://github.com/stack-of-tasks/install-sot/pull/13#issuecomment-24574401 .

elie-moussy commented 11 years ago

I have forked the redundant_manipulator_control and I created a topic/eigen in it. The I did the same to laas/ros. What should I do next in order to make the script install my redundant manipulator control please?

olivier-stasse commented 5 years ago

We are not using this system anymore to compile and install the SoT. Thanks for the contribution and so sorry for this loooooooong delay.