search

stack-of-tasks / install-sot

Bash script to install the repositories of Stack Of Tasks
0 stars 7 forks source link

Installing automatically ROS when script is launched #6

Closed thomas-moulard closed 11 years ago

thomas-moulard commented 11 years ago

How about installing automatically ROS?

@francois-keith Is there a reason this is not done currently?

For some reason the ROS repositories are added to /etc/apt/sources.list.d in step 0 but the script fails before if this is not done manually.

Any reason for this? What about making the ROS install automatic to fix the Travis test on this repo?

francois-keith commented 11 years ago

Hello Thomas,

Indeed, this was a mistake. The pull request associated to commit d84ef95 corrects that. It both prevents the exit command if ros is not found and remove the useless overwrite of ros variables.

Thanks for the report.

François

thomas-moulard commented 11 years ago

Thanks for this Francois, now the script seems to work perfectly :v:

thomas-moulard commented 11 years ago

It appears I was a bit too overreacting about the build being perfect but still... way better than before ;)