search

stack-of-tasks / install-sot

Bash script to install the repositories of Stack Of Tasks
0 stars 7 forks source link

ROS version should be set to a sensible default #8

Closed thomas-moulard closed 11 years ago

thomas-moulard commented 11 years ago

The current default ROS version is electric which will soon disappear. What about making the -r flag a requirement?

Another way would be to detect automatically the last version of ROS available on the system.

francois-keith commented 11 years ago

Hello Thomas,

I think that making the -r flag a requirement will make the script quite painful to use. IMHO, having to type every time -r hydro in command line will soon be daunting.

I think that a good compromise would be to avoid giving a default value to ROS_VERSION (*) and stop the script if it has not been HARD_CODED nor given with the -r flag.

(*) ie remove the lines

if [ "$ROS_VERSION" == "" ]; then
  ROS_VERSION=electric # ROS VERSION by default electric
fi

François

olivier-stasse commented 11 years ago

Why not detecting the ros version installed on the system and give the user a choice ? Otherwise IMHO, I would support Francois suggestion.

thomas-moulard commented 11 years ago

I pushed @francois-keith idea. If not version is set it fails, if ROS_VERSION is set it is used. If -r is passed it takes precedence over the environment variable.

olivier-stasse commented 11 years ago

Thanks Thomas !