stackgl / glsl-transpiler

Transpile GLSL to JS
http://stackgl.github.io/glsl-transpiler/
175 stars 21 forks source link

added failing test, where round brackets are incorrectly removed/missing #27

Closed lfdoherty closed 8 years ago

lfdoherty commented 8 years ago

I tried to transpile glsl-noise, and found a bug. Here's a test that shows the problem. I tried to fix it myself, but I haven't found where the error occurs yet - simpler cases with just the expression seem to correctly retain the brackets.

lfdoherty commented 8 years ago

I should add - this is very exciting project! Debugging shaders is never fun, and this tool suggests the possibility of doing things like stepping through shader code, asserting, etc., which would be invaluable.

dy commented 8 years ago

@lfdoherty thank you for the awesome test case! Fixed in 7376dbf2d76bd3584340a329f24e6e9c4ad5cc52