Closed sjpb closed 3 years ago
Given AccountingStorageLoc
can't currently be controlled from the role, and goes away in ohpc v2.1 anyway, we don't need to worry about that. I think we should fix it though so openhpc_slurm_job_comp_loc
/ JobCompLoc
is guaranteed to exist if openhpc_slurm_job_comp_type
/ JobCompType
is set to jobcomp/filetxt
. Otherwise the user has to do that before running the role.
Next question is whether the role's default for JobCompLoc should be changed to /var/log/slurm_jobcomp.log
or not. I suggest not given that is another change, and the docs for DefaultStorageLoc
suggest using the same file for both accounting and job completion storage is ok anyway.
In openhpc v2.0 / slurm 20.02.5 the
filetxt
storage type can be used for either/both accounting storage and job completion storage. Locations for these are set byAccountingStorageLoc
andJobCompLoc
respectively. In openhpc v2.1 /slurm v20.11.3filetxt
storage can only be used for job completion storage. Both versions supportDefaultStorageLoc
which can fill in for the other*StorageLoc
parameters.As of v0.7.0 the situation with this role is as follows:
DefaultStorageLoc
is not specified in the slurm.conf template.filetxt
AccountingStorageLoc
is not specified in the slurm.conf template/var/log/slurm_jobacct.log
. This appears to be the internal Slurm default for DefaultStorageLoc (source). This file is not part of any package, and is not created by the role. So Slurm must create it itself.none
.JobCompLoc
which is/var/log/slurm_jobacct.log
. This appears to be inconsistent with Slurm's internal default of/var/log/slurm_jobcomp.log
(source) although it is the internal default for DefaultStorageLoc.If accounting storage type is set to
none
and job completion is set tofiletxt
, slurmctld dies on startup with a permissions error for/var/log/slurm_jobacct.log
. Changing theJobCompLoc
to be/var/log/slurm_jobcomp.log
doesn't help, and the file must be "manually" created before slurmctld starts.If
AccountingStorageLoc
is manually added to the slurm.conf template, with a non-default location, then slurmctld similarly dies similarly on startup too. So it appears that there is some special-case creation for/var/log/slurm_jobacct.log
, but only if it is used for accounting storage, not as job completion storage.Refs: