search

standardml / smackage

Smackage Package Manager for Standard ML
Other
122 stars 12 forks source link

Changes to use Poly/ML with smackage #28

Closed mclements closed 5 years ago

mclements commented 6 years ago

The following commit allowed smackage to work with Poly/ML 5.7.1 Release on Ubuntu 16.04 LTS.

I do not know whether the call to pkg-config will be portable.

I also tried using configure.ac to allow for the Poly/ML executable being called polyml or poly - but reverted those commits as the changes were too large.

Sincerely, Mark.

mclements commented 5 years ago

Would someone be able look at this pull request, please?

gian commented 5 years ago

@mclements Looks good! I'll merge this and push a release.

gian commented 5 years ago

FWIW, the pkg-config call appears to be portable on Mac OS. I got as far as having it actually invoke polyml (although I needed to symlink poly to polyml). I didn't try going any further than that.

mclements commented 5 years ago

Thanks for following up on this. I also needed to symlink poly to polml on Ubuntu. I will ask the polyml mailing list about changing the default in the Makefile to POLYML=poly.

mclements commented 5 years ago

An alternative would be to assume GNU Make and:

POLYML := $(shell { command -v poly || echo polyml; } 2>/dev/null)