Fix to hyphenated taxonomies from uri

[Alt-Ben]

Super tiny change to fix the hyphenated taxonomies in term uris.

[what-the-diff[bot]]

PR Summary

• Changed hyphen to underscore in $taxonomy variable Improved variable naming for better code readability.

[jasonvarga]

Can you explain the situation this is fixing? This isn't in the core so it might also be happening there.

[Alt-Ben]

Hi Jason!

So I was using hyphenated taxonomies, and the urls that we'd generally use were just 404'ing. For example:

Taxonomy: Foo Bar Slug: /foo-bar Template: foo_bar.antlers.html

The slug wasn't being picked up, once I added the str_replace in, it all worked as expected.

Hopefully that helps - let me know if I've missed anything, or done something wrong!

[ryanmitchell]

While this change works for your use case, I dont think it's going to be sufficient for all (for example when a taxonomy is linked to a collection).

There are a couple of options:

1. We could just loop over all taxonomies and find where the uri matches... this works on the assumption there arent going to be a load of them so its a quick query.

2. We add a uri column to the taxonomies table, write an update script and migration, store the uri in the database, and use that for the query.

Either way the findTaxonomyHandleByUri method needs updated with the new logic.

[ryanmitchell]

Ok for now Ive opted for (1) as its the path of least friction for now. Let me know if this works for your use case.

[ryanmitchell]

@Alt-Ben did you get a chance to review this fix?

[Alt-Ben]

Sorry! Just got around to checking - all looks good from my side! Thank you!