search

statamic / eloquent-driver

Provides support for storing your Statamic data in a database, rather than flat files.
https://statamic.dev/tips/storing-content-in-a-database
MIT License
104 stars 72 forks source link

Restructure global variables to use its own table #168

Closed ryanmitchell closed 1 year ago

ryanmitchell commented 1 year ago

Following on from the conversation in https://github.com/statamic/eloquent-driver/issues/128, it makes sense to split globals and variables into separate tables, enabling splitting of configuration from data.

Ideally we would be able to offer a config for letting you opt into eloquent globals and variables separately, but from what I can see this is not possible in core as things stand. Scope for future development.

Closes: https://github.com/statamic/eloquent-driver/issues/128

royduin commented 1 year ago

Looking good to me! Curious what the challenge would be to separate it?

ryanmitchell commented 1 year ago

Not a lot to be honest, working on a PR to core at the moment

[Edit] Actually more than I thought, I'll need to come back to this.

ryanmitchell commented 1 year ago

@FrittenKeeZ I'd love a second pair of eyes on this if you had the time to check it over?

ryanmitchell commented 1 year ago

@royduin https://github.com/statamic/cms/pull/8343 if you want to follow along

royduin commented 1 year ago

Subscribed 👌🏻