search

statamic / eloquent-driver

Provides support for storing your Statamic data in a database, rather than flat files.
https://statamic.dev/tips/storing-content-in-a-database
MIT License
104 stars 71 forks source link

Statamic 5: Simplify `TestCase` #267

Closed duncanmcclean closed 2 months ago

duncanmcclean commented 2 months ago

This pull request simplifies the addon's TestCase, thanks to statamic/cms#9573.

I've also removed the custom partialMock method which no longer seems to be needed, the assertContainsHtml assertion which we don't seem to be using anywhere and the ConsoleKernel which also doesn't seem to be getting used.

ryanmitchell commented 2 months ago

hmm since this has merged a lot of the tests arent performing any assertions:

CleanShot 2024-04-11 at 06 32 30@2x

duncanmcclean commented 2 months ago

I think that may be related to the PHPUnit version. I'll take a look today.