status-im / community-dapp

Community directory curator dApp for Status
https://status-community-dapp.vercel.app
2 stars 5 forks source link

Review #94

Open felicio opened 1 year ago

felicio commented 1 year ago

note: in review, focus for example on wallet connection, waku connection, desktop browser, mobile browser, visible and clickable UI elements, rules, Communities Portal, etc.

note: for SNT bridging [@]0x-r4bbit shared https://www.notion.so/f24bc8154bfd4757989216dde0f50af0?v=eb8f6f301de94f4889ee6179d16eaf47&p=b54ff68bf78c4c61ad99973a52446063&pm=s

note: for comparing, https://github.com/status-im/community-dapp/compare/master...review

note: for deploying to production, create a new deployment from master or promote one of the preview deployments here https://vercel.com/docs/deployments/managing-deployments#promote-a-deployment-from-preview-to-production

image

what

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
community-dapp ✅ Ready (Inspect) Visit Preview 💬 10 unresolved
✅ 6 resolved
Jul 25, 2024 8:44am
jkbktl commented 1 year ago

https://github.com/status-im/community-dapp/pull/94/commits/9762c401feae296ec81ec02205b9fb966bd44c5d

This commit adds check if network is supported, if not it shows a warning on multiple places (mainly on top bar) and also adds "switch network" button (screenshot 1) which opens pop up (screenshot 2) with confirmation if user wants to switch network to correct one. It also blocks buttons in case user is not on supported network. See screenshots below.

Screenshot 2023-11-05 at 10 57 15 Screenshot 2023-11-05 at 10 57 24