UML problems

[keni7385]

I have reviewed your UML diagrams.

• There are many enums, such as EffectType, WeaponType and PowerupType, that are used actually as "type". This doesn't follow the OOP principles. If a label is used to distinguish among different behaviors in the code (maybe through a switch), could mean that a hierarchical structure is missing in the design.
• From the design, it's not so clear how you tackle targets in weapons. How can a player choose other ones and shoot them? i feel some logic is missing, as I see mainly getters and setters.
• Add cardinalities to relations, compositions, ....

Please fix these problems ASAP.

[daniCh8]

First of all, we would like to apologize for the delay of the answer: we wanted to effectively picture the usage of the weapons before getting back to you in order to be more concrete with our reply.

• We removed the EffectType enumeration, as it was not a good design idea. In regards to the WeaponType and PowerupType enumerations, we agree with you that they could be replaced with a hierarchical structure, and we were using some inheritance-based structures at first sight. However, when we showed our diagrams to a tutor, he answered that a type attribute would have been better to make everything simpler, since there were no differences between the child classes but the type, and (from his opinion) a casting would have been worst.
• We have updated the design to make the weapons usage clearer. Our idea is to make the player who is using the weapon decide between the different alternatives in which a weapon can be used. The code of this part has already been written.
• Added cardenalities to the diagram.

Thank you for your help. Let us know if there are other adjustments to make.

[keni7385]

We discussed during the class of 05-07, okay now