search

stefanw / bibbot

BibBot is a browser extension that removes the paywall on German online news sites using your library account's access to press databases.
https://stefanw.github.io/bibbot/
GNU General Public License v3.0
508 stars 78 forks source link

Fix new genios UI #327

Closed Travior closed 10 months ago

Travior commented 11 months ago

This would fix #320 The new login page requires an input event, otherwise the login credentials will be discarded on submit

Travior commented 11 months ago

I'm currently checking whether the bookmark icon is available as a method of checking whether the user is already logged in to genios. Not sure if this is the most elegant way, it works for now but I'm open for suggestions

stefanw commented 11 months ago

There are libraries that use the old interface, so we can't just replace the genios provider. Please create a new provider named new.genios.de (it's just a name). Then we can set a defaultSource on the affected providers to use that source.

Travior commented 11 months ago

I have changed my initial code to have the genios source configurable with an optional defaultSource in the provider Object. From my testing this should now only switch to the new.genios.de source for explicitly marked providers, I could however only test this with my library in Essen

Travior commented 11 months ago

It seems that (at least for my library) the old search link now redirects to the new genios UI (at least I get a 302 back). I'll try to change the search and scrape logic for the new UI as well

traubenzuckerberg commented 11 months ago

Ist das Problem jetzt behoben?

merula75 commented 10 months ago

@Travior thanks for this fix. I checked the list of providers and these 

bib-darmstadt.genios.de 
bib-halle.genios.de 
bib-jena.genios.de 
sbdresden.genios.de 
bib-oberhausen.genios.de 
bib-oranienburg.genios.de 
bib-luedenscheid.genios.de
bib-bayern.genios.de

use the same new login page. Could you add

    defaultSource: 'new.genios.de'

to them as well (would solve #324, #360)?

mangerlahn commented 10 months ago

Not too familiar with this, but may also apply to Leipzig:

stadtbib-leipzig.genios.de