search

stefanw / bibbot

BibBot is a browser extension that removes the paywall on German online news sites using your library account's access to press databases.
https://stefanw.github.io/bibbot/
GNU General Public License v3.0
508 stars 78 forks source link

New Genios: Support date filter #366

Closed ljrk0 closed 9 months ago

ljrk0 commented 10 months ago

The support for the new genios removed the date filter as well as the dbshortcut filter. This re-adds the former.

Cf. #364 on discussion of the format change and the different format of the new dbshortcut filter (not addressed in this PR).

stefanw commented 10 months ago

The problem is when the values are empty (not all sites are configured to use dates in queries), the URL will error due to the prefix (e.g. from_). I think we may need to add the ability to construct the URL via a function call.

ljrk0 commented 10 months ago

Ah, I see. Alternatively, fill dateStart with unix epoch day 0 and dateEnd with current date by default?

But construction through function calls would also help with the dbShortcuts