search

stefanw / bibbot

BibBot is a browser extension that removes the paywall on German online news sites using your library account's access to press databases.
https://stefanw.github.io/bibbot/
GNU General Public License v3.0
508 stars 78 forks source link

Fix paywall detection for tagesspiegel.de #389

Closed sinclair2 closed 9 months ago

sinclair2 commented 10 months ago

Fixes #302

stefanw commented 9 months ago

I strongly suspect that the class names are randomized to prevent scraping, so the .Er will not work.

sinclair2 commented 9 months ago

@stefanw I suspected the same and monitored the situation for a few days and it seemed stable. But meanwhile the IDs changed again. So yes, your solution is better.

But somehow your last commit broke tagesspiegel.de again. In the current version the plugin isn't triggering the query to genios. But the #paywal div gets a display: none, so something is happening. When I reset my Git to the commit before d429b128ff9c391fe0c44c9e9474c86e8ad2ed44 and install a plugin from this version, then it works fine.

And is there some documentation somewhere, what these query, main and paywall in the sites.ts do and how queries work? Is it possible to use some kind of query language like XPath to create more sophisticated queries (e.g. select the parent element of an element having a specific ID, or a sibling element)? I'm not a Typescript developer at all, so it's hard to figure out just from the code. But when I can help with fixing broken detection from time to time then I'm willing to contribute.