Closed devurandom closed 1 year ago
@devurandom Thank you for raising this issue. Originally I intentionally retained the Clojure syntax for separating namespace and name with /
for attribute names, but on reflection, I think it is preferable to adopt the OpenTelemetry recommendation.
I noticed that https://opentelemetry.io/docs/specs/otel/common/attribute-naming/ also proposes snake_case instead of kebab-case, that is more common in Clojure keywords:
For each multi-word dot-delimited component of the attribute name separate the words by underscores (i.e. use snake_case). For example
http.status_code
denotes the status code in the http namespace.
@devurandom Thanks for highlighting this naming convention for attributes. I have addressed this shortcoming in this commit.
https://opentelemetry.io/docs/reference/specification/common/attribute-naming/ says:
but
steffan-westcott.clj-otel.api.attributes/->attributes
generates names with a slash/
character delimiting the namespace instead of the dot.
character: