steffan-westcott / clj-otel

An idiomatic Clojure API for adding telemetry to your libraries and applications using OpenTelemetry.
https://cljdoc.org/d/com.github.steffan-westcott/clj-otel-api
Apache License 2.0
183 stars 12 forks source link

Update tutorial to emit OTLP-formatted traces #7

Closed aisamu closed 1 year ago

aisamu commented 1 year ago

From https://www.jaegertracing.io/docs/1.6/client-libraries/#deprecating-jaeger-clients

Since v1.35, the Jaeger backend can receive trace data from the OpenTelemetry SDKs in their native OpenTelemetry Protocol (OTLP).

(Thanks for taking the time to write the tutorial!)

steffan-westcott commented 1 year ago

@aisamu Thank you for highlighting the migration of Jaeger to use OTLP. This is a good step forward for the OpenTelemetry community as it removes potential confusion for users.

I looked at your pull request and found it was missing some necessary configuration to make it work correctly. Briefly:

I have addressed these points for the tutorial and examples in this commit.

aisamu commented 1 year ago

Thanks for addressing those! I've tested it only with the all-in-one binary, which I suppose comes with all that preconfigured.