steno-aarhus / legliv

UK Biobank Project
0 stars 0 forks source link

refactor: second pass for a code review #4

Closed lwjohnst86 closed 3 months ago

lwjohnst86 commented 3 months ago

@steno-aarhus/ukbiobank-team Pinging for those interested in learning from another code-review.

Mostly I converted functions into a consistent data in, data out format, remove external dependencies within the function, moved the functions and data processing over into the targets build.

I added several TODO items to come back to later and to point out things for discussion and for @nielsbock and @Fie-Langmann (?) to look into more.