search

stephenh / mirror

A tool for real-time, two-way sync for remote (e.g. desktop/laptop) development
Apache License 2.0
391 stars 35 forks source link

Add Dockerfile? #14

Closed njam closed 6 years ago

njam commented 6 years ago

Mirror is a very nice program, thanks!

I've created a Docker image with mirror, to easily deploy it to remote VMs. Are you interested in having a Dockerfile in the repo? If yes, then it could be nice if there was an official image on some container registry, so anyone can fetch it from there. If not, then that's also fine and I can publish it on some personal registry.

Let me know what you think.

stephenh commented 6 years ago

Hi @njam; great, this looks really cool!

I'm a super Docker-newbie, but having an official image makes sense to me.

What container registry would you recommend?

njam commented 6 years ago

Cool! I've been using "Docker Hub" and "Google Container Registry" in the past, but don't like neither of them very much for open-source projects. I just tested "Quay.io" and would suggest to give it a try. They allow for easy permissions configurations, have robots accounts, and a simple build configuration.

If you agree, then I would suggest that you do the following:

  1. Create an account at Quay.io: https://quay.io/plans/ (looks like it costs money, but will be free for public repo)
  2. Create a new repository on Quay.io (stephenh/mirror). Make it public and initialize it with Link to a GitHub Repository Push. I would suggest these settings: Trigger: "Trigger for all branches and tags (default)" Dockerfile: "/Dockerfile" Context: "/"
  3. In the new repositoy's settings you could give me ("njam") admin permissions if you want.

wdyt?

njam commented 6 years ago

Should I incorporate some notes about using the Docker image into the project's README?

stephenh commented 6 years ago

Sure, sounds like a good plan. I went through the Quay setup, following your directions, and it's building now:

https://quay.io/repository/stephenh/mirror/build/52430dc9-444c-4867-b3e4-924902ad755f

I added you as a member to the Quay project.

Adding a Docker-specific section to the readme sounds like a good idea, that'd be great. Thanks!

njam commented 6 years ago

I went through the Quay setup, following your directions, and it's building now.

Cool, thanks! I wanted to move the Dockerfile to the root of the repo, as it is quite common if it's ok with you. The reason the build is failing now is because I didn't do that yet.

I opened a ticket to track those fixes and some other improvements: https://github.com/stephenh/mirror/issues/15