search

stephenh / mirror

A tool for real-time, two-way sync for remote (e.g. desktop/laptop) development
Apache License 2.0
391 stars 37 forks source link

./gradlew shadowJar produces wrong jar name #35

Closed ediphy-azorab closed 4 years ago

ediphy-azorab commented 5 years ago

It's possibly an artifact of my environment, but the output of the shadowJar task is called mirror.jar on my system, not mirror-all.jar.

It's simple enough to fix up the build scripts, but I don't want to do it if it's only my box it's happening on.

stephenh commented 4 years ago

Huh, you're right. This probably changed when I bumped a gradle version/something and didn't realize it.

I started changing all of the mirror-alls to just mirror, like you did in in #36, but also upgraded the gradle shadow plugin, and turns out that fixed it.

So, probably was a gradle upgrade not agreeing with an old version of the shadow plugin, but looks to be fixed now. Thanks!