search

stephenharris / WP-MarkDown

WP-MarkDown plug-in. Allows Markdown to be enabled in posts, comments and bbPress forums.
http://wordpress.org/extend/plugins/wp-markdown/
112 stars 19 forks source link

PHP7 Compatibilty #67

Closed mAAdhaTTah closed 7 years ago

mAAdhaTTah commented 8 years ago

Getting this error for several of the Markdown-related classes:

[23-Jan-2016 20:04:15 UTC] PHP Deprecated:  Methods with the same name as their class will not be constructors in a future version of PHP; Markdownify has a deprecated constructor in /path/to/plugins/wp-markdown/markdownify/markdownify.php on line 58
[23-Jan-2016 20:04:15 UTC] PHP Stack trace:
[23-Jan-2016 20:04:15 UTC] PHP   1. {main}() /path/to/wp/wp-admin/admin-ajax.php:0
[23-Jan-2016 20:04:15 UTC] PHP   2. require_once() /path/to/wp/wp-admin/admin-ajax.php:22
[23-Jan-2016 20:04:15 UTC] PHP   3. require_once() /path/to/wp/wp-load.php:42
[23-Jan-2016 20:04:15 UTC] PHP   4. require_once() /path/to/wp-config.php:9
[23-Jan-2016 20:04:15 UTC] PHP   5. include_once() /path/to/wp/wp-settings.php:254
lkraav commented 8 years ago

Yeah, this is real. Do any of the maintainers have bandwidth to get a small point release out?

stephenharris commented 8 years ago

Yup, the Markdown_Parser is very dated. I'd be happy to accept a PR to use a new version so long as tests pass.

magadanskiuchen commented 8 years ago

I've just submitted a pull request to address this (and add a few more adjustments to the code in terms of access modifiers): #68