stevensblueprint / inreach-website

https://inreach-website.vercel.app
6 stars 1 forks source link

Feature/custom color field #56

Closed j-ferber closed 3 months ago

j-ferber commented 3 months ago

Added a custom color field to the CMS so they can edit the color of the components.

image

Can current be tested on: http://localhost:3000/admin/index.html#/~/example-actions

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
inreach-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2024 4:40pm
ShawnAviles commented 3 months ago

Just to provide what I found regarding the issue of having each button have its corresponding background color:

I think keeping the colors how they are no is a design decision from the Tina team to prevent crazy styling choices from being used as well as handle some past CSS issues they had

I think another approach we can try would be to have the hex values within an object outside of that component so we can map over them and set the background style to that hex using a basic style prop. But that means our color system would exist in 3 places (Tailwind Config, Mantine, and here) which wouldn't be the best.

Anyways, we can come back to this after the MVP