stevenyvr987 / overdrive-evergreen-opac

Automatically exported from code.google.com/p/overdrive-evergreen-opac
0 stars 0 forks source link

Progress message of action buttons not working #42

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The progress message shows up while an XHR request is in the progress state. It 
was working some time ago.

Also, it might be good to replace the text message with the progress bar that 
we are now using.

Original issue reported on code.google.com by steven3...@gmail.com on 19 Aug 2014 at 7:56

GoogleCodeExporter commented 9 years ago
Correction: it doesn't work with jQuery ajax method, because it doesn't 
implement the progress handler. It was working, but that was when I simulated 
ajax by making my own deferred object and calling the notify method.

Original comment by steven3...@gmail.com on 30 Aug 2014 at 9:14

GoogleCodeExporter commented 9 years ago
We can use the beforeSend callback hook of the jQuery ajax. We set the callback 
to the progress function we were trying to call before. If the ajax call fails 
or succeeds, the content part of the action dialogue is replaced by new 
content, so the progress will successfully show or hide.

It will be good to use the jquery-ui progress bar instead of progress text.

Original comment by steven3...@gmail.com on 30 Aug 2014 at 10:28

GoogleCodeExporter commented 9 years ago
Done using beforeSend callback. Not totally satisfactory in terms of 
cleanliness. Also, generalized rendering of action dialogue to use progress bar 
as a default. Thus, for a progress scenario, it is sufficient to rely on the 
default.

Original comment by steven3...@gmail.com on 31 Aug 2014 at 6:16