search

stm32duino / STM32Ethernet

Arduino library to support Ethernet for STM32 based board
156 stars 43 forks source link

macAddress function name #35

Closed ramboerik closed 4 years ago

ramboerik commented 4 years ago

Hi, I'm using the library and noticed that the name of the function macAddress differs from arduino's own library. 

Arduino Ethernet: MACAddress
STM32Ethernet: macAddress

This is a bit frustrating as I'm compiling for multiple library implementations and is forced to write a wrapper around the function to unify the name. Could the function name be changed to MACAddress alternative add a wrapper to make it interchangeable with Arduino's library?

fpistm commented 4 years ago

Hi @ramboerik Thanks for this issue. I will rename it and does not kept backward compatibility for this to ensure user use the correct name.

ramboerik commented 4 years ago

Thanks 👍!