search

stm32duino / STM32Ethernet

Arduino library to support Ethernet for STM32 based board
163 stars 44 forks source link

Consider adding method end() and operator bool() in EthernetServer #73

Closed JAndrassy closed 1 year ago

JAndrassy commented 1 year ago

I did a research on how is Arduino networking API implemented in libraries and I see your library is missing useful functions in the Server class. https://github.com/JAndrassy/Arduino-Networking-API/blob/main/ArduinoNetAPILibs.md#server-class

fpistm commented 1 year ago

Hi @JAndrassy Looking at official API documentation, I didn't see end(). https://www.arduino.cc/reference/en/libraries/ethernet/

Only bool: https://www.arduino.cc/reference/en/libraries/ethernet/ifserver/

Feel free to provide a PR.

JAndrassy commented 1 year ago

Feel free to provide a PR.

sorry no.. there are too many libraries with different issues. I don't have a hardware for this one. (most of the [PR ] links in the linked document are my PR and still many to do)

Arduioi used end() for the first time in official library in the new WiFiS3 library for the Uno R4 WiFi. that library doesn't have a doc yet. but many other networking libraries have end(). users ask for it for temporarily started servers.

fpistm commented 1 year ago

Hi @JAndrassy I've made the implementation in #77