search

stokito / grails-cookie

Makes dealing with cookies easy. Provides an injectable service and tag to easily get, set, and delete cookies with one line
http://grails.org/plugin/cookie
16 stars 12 forks source link

Adding ability to externalize config and use string booleans. #33

Closed ctoestreich closed 9 years ago

ctoestreich commented 9 years ago

Also doing cyclomatic complexity cleanup on code

stokito commented 9 years ago

Hi @ctoestreich Thanks for your pull request, it's looks cool. Travis Ci says that test are failed https://travis-ci.org/stokito/grails-cookie Could you check why? I can do it myself, if you not interested

stokito commented 9 years ago

I reverted some small changes:

  1. return keyword is always explicit to avoid errors during refactorings
  2. writeCookieToResponse() doesn't change cookie value, so it should be void
  3. getDefaultCookiePath(String path = '') was reverted because this default param value never used.
ctoestreich commented 9 years ago

Thanks for adding so quickly. The changes you made above make sense. I noticed that the grails required version was bumped to 2.4 > *. This is not exactly the case. I tested this with 2.2.1, 2.3.8 and 2.4.0 and all versions of grails > 2.2 were able to use the plugin. I reverted the required version back to 2.2 to allow broader use of the plugin. Thanks!

stokito commented 9 years ago

Yep, but problem was with running unit tests, they failed in grails 2.2.0