search

stokito / grails-cookie

Makes dealing with cookies easy. Provides an injectable service and tag to easily get, set, and delete cookies with one line
http://grails.org/plugin/cookie
16 stars 12 forks source link

Only needs 2.2 to run. #34

Closed ctoestreich closed 9 years ago

ctoestreich commented 9 years ago

Thanks for adding so quickly. The changes you made above make sense. I noticed that the grails required version was bumped to 2.4 > *. This is not exactly the case. I tested this with 2.2.1, 2.3.8 and 2.4.0 and all versions of grails > 2.2 were able to use the plugin. I reverted the required version back to 2.2 to allow broader use of the plugin. Thanks!

ctoestreich commented 9 years ago

screen shot 2015-01-23 at 10 27 45 am

stokito commented 9 years ago

test-app work only from 2.4 I don't know why

ctoestreich commented 9 years ago

They changed public interface HttpServletRequest extends ServletRequest in grails 2.4.0. That is only used in test, this causes no issues running the plugin from a project on 2.2+. 

 On Tuesday, January 27, 2015 1:38 PM, Sergey Ponomarev <notifications@github.com> wrote:

test-app work only from 2.4 I don't know why— Reply to this email directly or view it on GitHub.

stokito commented 9 years ago

I decided to make two versions of cookie plugin: 1.2 for Grails 2.2.x and 1.4 for Grails 2.4+

They are already published and you can use them.

Thanks, and sorry for waiting