search

stolostron / klusterlet-addon-controller

Apache License 2.0
4 stars 22 forks source link

remove work-manager addon and fix values annotations update failure #108

Closed zhiweiyin318 closed 2 years ago

zhiweiyin318 commented 2 years ago
  1. remove watch work-manager . the ocm-controller can handle the image override and nodeselector.
  2. fix the values annotation cannot be reconciled back when the images changes.

Signed-off-by: Zhiwei Yin zyin@redhat.com

zhiweiyin318 commented 2 years ago

/assign @yangle

openshift-ci[bot] commented 2 years ago

@zhiweiyin318: GitHub didn't allow me to assign the following users: yangle.

Note that only stolostron members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/stolostron/klusterlet-addon-controller/pull/108#issuecomment-1070678163): >/assign @yangle Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

xuezhaojun commented 2 years ago

/lgtm

xuezhaojun commented 2 years ago

/lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xuezhaojun, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/codeready-toolchain/toolchain-e2e/blob/main/OWNERS)~~ [zhiweiyin318] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment