search

stolostron / klusterlet-addon-controller

Apache License 2.0
4 stars 22 forks source link

remove old finalizer and fix the cleanup issues #111

Closed zhiweiyin318 closed 2 years ago

zhiweiyin318 commented 2 years ago

Signed-off-by: Zhiwei Yin zyin@redhat.com

  1. fix cleanup controller does not run
  2. remove the klusterletAddonConfig finalizer from the managedCluster
  3. remove the klusterletAddonConfig info from the app and work-manager clusterManagementAddons
  4. remove the Progressing condition from the old managedClusterAddons
  5. delete work-manager addon when the managedCluster is deleting
  6. add ut for cleanup controller
zhiweiyin318 commented 2 years ago

/assign @elgnay

zhiweiyin318 commented 2 years ago

/retest

zhiweiyin318 commented 2 years ago

/retest

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

20.6% 20.6% Coverage
0.0% 0.0% Duplication

elgnay commented 2 years ago

/lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elgnay, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/klusterlet-addon-controller/blob/main/OWNERS)~~ [elgnay,zhiweiyin318] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zhiweiyin318 commented 2 years ago

related issue: https://github.com/stolostron/backlog/issues/20474